Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: performance drop caused by UI animation #857

Merged
merged 9 commits into from
Feb 29, 2024
Merged

fix: performance drop caused by UI animation #857

merged 9 commits into from
Feb 29, 2024

Conversation

anhappdev
Copy link
Collaborator

@anhappdev anhappdev commented Feb 20, 2024 •
edited
Loading

The progress screen now looks like this and has no animation:

2024-02-22:

  • I added a new setting so we can quickly test different animation styles. For comparison, I added back the old dotted circle animation we had before the UI change.
  • In my testing with an old Samsung phone, dotted or gradient circle produce similar throughput, and no animation produces a slightly higher throughput. So we should decide whether we want a progress animation or not, then I will update the code and remove the setting.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@mohitmundhragithub
Copy link
Contributor

mohitmundhragithub commented Feb 23, 2024 •
edited
Loading

Thanks a lot. We experimented with these settings.

  1. "No animation" gives the best performance.
  2. "dotted circle" gives performance as good as the previous UI.
  3. "gradient circle" gives performance quite a bit less than previous UI.

user experience wise, all the three options looks ok to us.

@anhappdev
Copy link
Collaborator Author

@mohitmundhragithub Thanks for the feedback. BTW, I forgot to mention, if you don't use the release APKs from GitHub but build the app locally, please make sure you run it with the --profile flag flutter run --profile when testing performance.

@mohitmundhragithub
Copy link
Contributor

@mohitmundhragithub Thanks for the feedback. BTW, I forgot to mention, if you don't use the release APKs from GitHub but build the app locally, please make sure you run it with the --profile flag flutter run --profile when testing performance.

which portion will it enable?

@freedomtan
Copy link
Contributor

no animation, but when the go button pressed, make the outer circle bright.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@anhappdev anhappdev marked this pull request as ready for review February 27, 2024 10:56
@anhappdev anhappdev requested a review from a team as a code owner February 27, 2024 10:56
@mohitmundhragithub
Copy link
Contributor

This PR may be required to be cherry-picked to submission-v4.0 branch as well.

@anhappdev anhappdev merged commit 89991f5 into master Feb 29, 2024
21 checks passed
@anhappdev anhappdev deleted the 856/ui-performance-drop-check branch February 29, 2024 08:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mohitmundhragithub mohitmundhragithub mohitmundhragithub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for performance impact of new UI
3 participants
@anhappdev @mohitmundhragithub @freedomtan